Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax errors in comments #18746

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

lishaokai1995
Copy link
Contributor

@lishaokai1995 lishaokai1995 commented May 29, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Fix syntax errors in comments

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@lishaokai1995 lishaokai1995 requested a review from a team as a code owner May 29, 2023 01:52
Signed-off-by: lishaokai1995 <lishaokai1995@126.com>
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #18746 (3c9bea1) into main (4652d75) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 3c9bea1 differs from pull request most recent head 470061d. Consider uploading reports for the commit 470061d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18746      +/-   ##
==========================================
- Coverage   44.81%   44.76%   -0.05%     
==========================================
  Files         235      235              
  Lines       13067    13067              
  Branches     2665     2665              
==========================================
- Hits         5856     5850       -6     
- Misses       6917     6922       +5     
- Partials      294      295       +1     
Flag Coverage Δ
unittests 44.76% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@AllForNothing AllForNothing merged commit 04833d2 into goharbor:main May 29, 2023
@OrlinVasilev
Copy link
Member

@lishaokai1995 congrats on merging your first PR here :) welcome to the club!

WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Signed-off-by: lishaokai1995 <lishaokai1995@126.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Signed-off-by: lishaokai1995 <lishaokai1995@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants