Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherry-pick) Return error when proxy cache get too many request error(429) #18751

Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented May 29, 2023

Add 429 too many request error in http error
Fixes #18707

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 29, 2023 05:49
@stonezdj stonezdj added the release-note/update Update or Fix label May 29, 2023
@stonezdj stonezdj assigned wy65701436 and zyyw and unassigned Vad1mo May 29, 2023
@stonezdj stonezdj changed the title Return error when proxy cache get too many request error(429) (cherry-pick) Return error when proxy cache get too many request error(429) May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #18751 (13ed6b1) into release-2.7.0 (ca8bbad) will decrease coverage by 0.02%.
The diff coverage is 16.66%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #18751      +/-   ##
=================================================
- Coverage          66.40%   66.39%   -0.02%     
=================================================
  Files               1012     1012              
  Lines             108643   108653      +10     
  Branches            2677     2677              
=================================================
- Hits               72146    72140       -6     
- Misses             32533    32547      +14     
- Partials            3964     3966       +2     
Flag Coverage Δ
unittests 66.39% <16.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/proxy/controller.go 15.84% <0.00%> (+0.92%) ⬆️
src/lib/http/error.go 92.68% <ø> (ø)
src/pkg/registry/client.go 43.67% <0.00%> (-0.18%) ⬇️
src/server/middleware/repoproxy/proxy.go 2.70% <0.00%> (-0.05%) ⬇️
src/lib/errors/const.go 92.30% <100.00%> (+0.64%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 2.7.0_return_429_proxy_cache branch from ed7f579 to 61b87f9 Compare May 31, 2023 03:58
  Add 429 too many request error in http error
  Change e2e container for 2.7.x
  Fixes goharbor#18707

Signed-off-by: stonezdj <stonezdj@gmail.com>
@stonezdj stonezdj force-pushed the 2.7.0_return_429_proxy_cache branch from 61b87f9 to 13ed6b1 Compare May 31, 2023 06:56
@stonezdj stonezdj merged commit 51a4c93 into goharbor:release-2.7.0 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants