-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icons #18767
update icons #18767
Conversation
Signed-off-by: vndroid <diracsvip@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #18767 +/- ##
===========================================
- Coverage 67.39% 44.67% -22.73%
===========================================
Files 985 236 -749
Lines 107969 13178 -94791
Branches 2698 2698
===========================================
- Hits 72770 5887 -66883
+ Misses 31298 6997 -24301
+ Partials 3901 294 -3607
Flags with carried forward coverage won't be shown. Click here to find out more. |
@vndroid Thanks for the PR. |
@vndroid The only change is the bg-color(from white to transparent), right? |
Right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vndroid @OrlinVasilev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hold for discussing
Already addressed to CNCF if we need to follow some standard or something! maybe we can discuss it on the next CM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CNCF is ok with the change as does not break any branding or color schemas! CNCF service desk : CNCFSD-1848
Replace the icon with a transparent background to adapt to Chrome or Firefox with different colors or custom themes.
The effect is shown in the picture, the left side is the original, and the right side is updated, you can see that it is more friendly for the different colors or custom themes.