Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Referrers API testcase #18775

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

YangJiao0817
Copy link
Member

Fix #18617

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#18617

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc... labels Jun 1, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner June 1, 2023 06:14
@YangJiao0817 YangJiao0817 self-assigned this Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #18775 (8007aae) into main (a98711c) will decrease coverage by 22.58%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18775       +/-   ##
===========================================
- Coverage   67.37%   44.79%   -22.58%     
===========================================
  Files         980      235      -745     
  Lines      106774    13067    -93707     
  Branches     2665     2665               
===========================================
- Hits        71936     5853    -66083     
+ Misses      30972     6918    -24054     
+ Partials     3866      296     -3570     
Flag Coverage Δ
unittests 44.79% <ø> (-22.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 751 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 97c1fdc into goharbor:main Jun 1, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Fix goharbor#18617

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Fix goharbor#18617

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Referrers API testcase
6 participants