Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman pull & push testcase #18790

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jun 5, 2023

Fix #18788

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 requested a review from a team as a code owner June 5, 2023 09:13
@YangJiao0817 YangJiao0817 self-assigned this Jun 5, 2023
@YangJiao0817 YangJiao0817 added the release-note/infra Infra related changes e.g. release, test, ship etc... label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #18790 (219c619) into main (6e2b79a) will decrease coverage by 3.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18790      +/-   ##
==========================================
- Coverage   70.52%   67.34%   -3.18%     
==========================================
  Files         745      980     +235     
  Lines       93797   106864   +13067     
  Branches        0     2665    +2665     
==========================================
+ Hits        66146    71969    +5823     
- Misses      24074    31029    +6955     
- Partials     3577     3866     +289     
Flag Coverage Δ
unittests 67.34% <ø> (-3.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 238 files with indirect coverage changes

Fix goharbor#18788

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 force-pushed the add-podman-testcase-py branch from cd3072b to 219c619 Compare June 6, 2023 01:50
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 61d74b9 into goharbor:main Jun 6, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Fix goharbor#18788

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Fix goharbor#18788

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/pytest-e2e release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add podman pull & push testcase
5 participants