Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Podman push command to the UI #18810

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jun 12, 2023

  1. Fixes Add podman command prompts #18781
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner June 12, 2023 07:33
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jun 12, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #18810 (48d56a4) into main (31a46a1) will increase coverage by 22.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18810       +/-   ##
===========================================
+ Coverage   44.74%   67.40%   +22.66%     
===========================================
  Files         235      980      +745     
  Lines       13082   106883    +93801     
  Branches     2671     2671               
===========================================
+ Hits         5854    72049    +66195     
- Misses       6934    30960    +24026     
- Partials      294     3874     +3580     
Flag Coverage Δ
unittests 67.40% <100.00%> (+22.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ared/components/push-image/push-image.component.ts 39.13% <100.00%> (+2.76%) ⬆️

... and 750 files with indirect coverage changes

@AllForNothing AllForNothing force-pushed the podman branch 2 times, most recently from 855aba3 to 399c687 Compare June 13, 2023 01:18
1. Fixes goharbor#18781

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit ca94a23 into goharbor:main Jun 13, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Fixes goharbor#18781

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Fixes goharbor#18781

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add podman command prompts
5 participants