refactor: migrate the redis command keys to scan #18825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18825 +/- ##
==========================================
+ Coverage 67.38% 67.40% +0.02%
==========================================
Files 981 981
Lines 106901 106925 +24
Branches 2678 2678
==========================================
+ Hits 72030 72078 +48
+ Misses 30998 30980 -18
+ Partials 3873 3867 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
force-pushed
the
refactor/filter-keys-from-cache
branch
10 times, most recently
from
868b3ac to
38ce645
Compare
stonezdj
approved these changes
Jun 27, 2023
Refine the cache interface, migrate the Keys to Scan, change the redis underlying keys command to scan. Signed-off-by: chlins <chenyuzh@vmware.com>
chlins
force-pushed
the
refactor/filter-keys-from-cache
branch
from
38ce645 to
d091ea1
Compare
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
Refine the cache interface, migrate the Keys to Scan, change the redis underlying keys command to scan. Signed-off-by: chlins <chenyuzh@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
Refine the cache interface, migrate the Keys to Scan, change the redis underlying keys command to scan. Signed-off-by: chlins <chenyuzh@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the cache interface, migrate the Keys to Scan, change the redis underlying keys command to scan.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: