-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new client Podman to the pull command #18857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllForNothing
added
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
release-note/docs
Docs changes(made and needed)
doc-impact
Engineering issues that will require a change in user docs
and removed
release-note/docs
Docs changes(made and needed)
labels
Jun 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #18857 +/- ##
===========================================
+ Coverage 44.79% 70.56% +25.76%
===========================================
Files 235 745 +510
Lines 13083 93800 +80717
Branches 2671 0 -2671
===========================================
+ Hits 5861 66193 +60332
- Misses 6928 24025 +17097
- Partials 294 3582 +3288
Flags with carried forward coverage won't be shown. Click here to find out more. |
YangJiao0817
approved these changes
Jun 27, 2023
1.Fixes goharbor#18832 Signed-off-by: AllForNothing <sshijun@vmware.com>
AllForNothing
force-pushed
the
copy-command
branch
from
June 27, 2023 02:11
3f38fb4
to
8f58559
Compare
wy65701436
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1.Fixes goharbor#18832 Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1.Fixes goharbor#18832 Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-impact
Engineering issues that will require a change in user docs
release-note/enhancement
Label to mark PR to be added under release notes as enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Fixes #18832
Remove the pull command column from the datagrid and add
COPY PULL COMMAND
dropdown at the top right of the datagrid:Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: