Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new client Podman to the pull command #18857

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jun 27, 2023

1.Fixes #18832

Remove the pull command column from the datagrid and add COPY PULL COMMAND dropdown at the top right of the datagrid:
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner June 27, 2023 01:29
@AllForNothing AllForNothing added release-note/enhancement Label to mark PR to be added under release notes as enhancement release-note/docs Docs changes(made and needed) doc-impact Engineering issues that will require a change in user docs and removed release-note/docs Docs changes(made and needed) labels Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #18857 (8f58559) into main (1d6c02f) will increase coverage by 25.76%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18857       +/-   ##
===========================================
+ Coverage   44.79%   70.56%   +25.76%     
===========================================
  Files         235      745      +510     
  Lines       13083    93800    +80717     
  Branches     2671        0     -2671     
===========================================
+ Hits         5861    66193    +60332     
- Misses       6928    24025    +17097     
- Partials      294     3582     +3288     
Flag Coverage Δ
unittests 70.56% <ø> (+25.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 980 files with indirect coverage changes

1.Fixes goharbor#18832

Signed-off-by: AllForNothing <sshijun@vmware.com>
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit d36ca80 into goharbor:main Jun 27, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1.Fixes goharbor#18832

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Wilfred Almeida <60785452+WilfredAlmeida@users.noreply.github.com>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1.Fixes goharbor#18832

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-impact Engineering issues that will require a change in user docs release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple clients for pull command copy button
6 participants