Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the keyword in the testcase #18898

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 6, 2023

Pipeline execution time from 3 hr 32 min to 2 hr 10 min.
Fix #17952

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#17952

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #18898 (81ca8eb) into main (c8120d5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18898      +/-   ##
==========================================
- Coverage   67.38%   67.36%   -0.02%     
==========================================
  Files         981      981              
  Lines      107194   107194              
  Branches     2698     2698              
==========================================
- Hits        72228    72209      -19     
- Misses      31085    31102      +17     
- Partials     3881     3883       +2     
Flag Coverage Δ
unittests 67.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit fb52fdb into goharbor:main Jul 6, 2023
@OrlinVasilev
Copy link
Member

that's the fastest merge ever! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the keyword in the testcase
5 participants