Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add password/secret length check to be <= 128 #18916

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 11, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)
Resolve task 5 in issue 18091

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw requested a review from a team as a code owner July 11, 2023 08:11
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #18916 (31b2439) into main (98f592f) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18916      +/-   ##
==========================================
- Coverage   67.32%   67.32%   -0.01%     
==========================================
  Files         981      981              
  Lines      107342   107342              
  Branches     2698     2698              
==========================================
- Hits        72270    72266       -4     
- Misses      31189    31192       +3     
- Partials     3883     3884       +1     
Flag Coverage Δ
unittests 67.32% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/server/v2.0/handler/robot.go 4.31% <0.00%> (ø)
src/controller/robot/controller.go 55.63% <100.00%> (ø)
src/server/v2.0/handler/user.go 14.68% <100.00%> (-1.52%) ⬇️

... and 6 files with indirect coverage changes

@zyyw zyyw added the release-note/update Update or Fix label Jul 11, 2023
@zyyw zyyw assigned stonezdj and AllForNothing and unassigned chlins and MinerYang Jul 11, 2023
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the api-validator-robot-account branch from 5f0d70a to 31b2439 Compare July 12, 2023 02:09
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants