-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add password/secret length check to be <= 128 #18916
Conversation
Codecov Report
@@ Coverage Diff @@
## main #18916 +/- ##
==========================================
- Coverage 67.32% 67.32% -0.01%
==========================================
Files 981 981
Lines 107342 107342
Branches 2698 2698
==========================================
- Hits 72270 72266 -4
- Misses 31189 31192 +3
- Partials 3883 3884 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
5f0d70a
to
31b2439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Resolve task 5 in issue 18091
Please indicate you've done the following: