Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the regex for policy name and the tooltip message #18947

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 18, 2023

  1. Fixes task 6 for Validators for Harbor APIs #18091

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner July 18, 2023 09:25
@AllForNothing AllForNothing added the release-note/update Update or Fix label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #18947 (9b2b4ad) into main (970bdab) will increase coverage by 3.14%.
The diff coverage is n/a.

❗ Current head 9b2b4ad differs from pull request most recent head e81efbc. Consider uploading reports for the commit e81efbc to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18947      +/-   ##
==========================================
+ Coverage   67.42%   70.56%   +3.14%     
==========================================
  Files         986      750     -236     
  Lines      108614    95436   -13178     
  Branches     2698        0    -2698     
==========================================
- Hits        73229    67343    -5886     
+ Misses      31452    24455    -6997     
+ Partials     3933     3638     -295     
Flag Coverage Δ
unittests 70.56% <ø> (+3.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 240 files with indirect coverage changes

@AllForNothing AllForNothing force-pushed the validator branch 2 times, most recently from 4defd2e to a548c58 Compare July 19, 2023 08:47
1. Fixes task 6 for goharbor#18091

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit b08dce4 into goharbor:main Jul 19, 2023
MinerYang pushed a commit that referenced this pull request Jul 24, 2023
1. Fixes task 6 for #18091

Signed-off-by: AllForNothing <sshijun@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants