Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong scanned artifact count when there are multiple report for an artifact #18975

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 22, 2023

Fix wrong scanned artifact count when there are multiple report for an artifact

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner July 22, 2023 01:36
@stonezdj stonezdj assigned stonezdj, wy65701436 and chlins and unassigned Vad1mo, zyyw and chlins Jul 22, 2023
@stonezdj stonezdj added the release-note/update Update or Fix label Jul 22, 2023
@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #18975 (04eb4db) into main (d7ff8bf) will increase coverage by 25.65%.
The diff coverage is n/a.

❗ Current head 04eb4db differs from pull request most recent head 17e03a2. Consider uploading reports for the commit 17e03a2 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18975       +/-   ##
===========================================
+ Coverage   44.91%   70.56%   +25.65%     
===========================================
  Files         244      748      +504     
  Lines       13386    95339    +81953     
  Branches     2747        0     -2747     
===========================================
+ Hits         6012    67279    +61267     
- Misses       7069    24437    +17368     
- Partials      305     3623     +3318     
Flag Coverage Δ
unittests 70.56% <ø> (+25.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/securityhub/dao/security.go 50.80% <ø> (ø)

... and 991 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23jul21_wrong_scanned_artifact branch from 5b24e59 to 08b3613 Compare July 24, 2023 07:28
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23jul21_wrong_scanned_artifact branch 2 times, most recently from a1ee0fd to 73e04f0 Compare July 24, 2023 12:15
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…n artifact

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 23jul21_wrong_scanned_artifact branch from 04eb4db to 17e03a2 Compare July 25, 2023 02:58
@stonezdj stonezdj merged commit d92aca9 into goharbor:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants