Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration script for 2.9 #18997

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Jul 25, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

add

  • internal_tls.strong_ssl_ciphers
  • jobservice.job_loggers
  • core.quota_update_provider

remove

  • external_database.notary_signer
  • external_database.notary_server

@MinerYang MinerYang added the release-note/update Update or Fix label Jul 25, 2023
@MinerYang MinerYang requested a review from a team as a code owner July 25, 2023 01:54
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #18997 (f17c3e8) into main (70554fe) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18997      +/-   ##
==========================================
+ Coverage   44.87%   44.99%   +0.11%     
==========================================
  Files         244      244              
  Lines       13386    13386              
  Branches     2747     2747              
==========================================
+ Hits         6007     6023      +16     
+ Misses       7076     7059      -17     
- Partials      303      304       +1     
Flag Coverage Δ
unittests 44.99% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@MinerYang MinerYang force-pushed the add_2.9_prepare_migrate branch from eab7b01 to eecabc8 Compare July 25, 2023 03:48
@MinerYang MinerYang assigned wy65701436 and unassigned Vad1mo and stonezdj Jul 25, 2023
@MinerYang MinerYang force-pushed the add_2.9_prepare_migrate branch 3 times, most recently from 711f206 to 8ab7d40 Compare July 25, 2023 07:27
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: yminer <yminer@vmware.com>

update quota_update_provider

update typo

update comment
@YangJiao0817 YangJiao0817 force-pushed the add_2.9_prepare_migrate branch from 8ab7d40 to f17c3e8 Compare July 25, 2023 08:50
@MinerYang MinerYang merged commit 8102304 into goharbor:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants