Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signer name #19001

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix signer name #19001

merged 1 commit into from
Jul 25, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 25, 2023

Append the signer name to the error message which will be returned by the client

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner July 25, 2023 07:08
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #19001 (6800a26) into main (c25a7ca) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

❗ Current head 6800a26 differs from pull request most recent head e7288d3. Consider uploading reports for the commit e7288d3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19001      +/-   ##
==========================================
- Coverage   67.40%   67.38%   -0.02%     
==========================================
  Files         992      992              
  Lines      108725   108727       +2     
  Branches     2747     2747              
==========================================
- Hits        73286    73267      -19     
- Misses      31507    31531      +24     
+ Partials     3932     3929       -3     
Flag Coverage Δ
unittests 67.38% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/server/middleware/contenttrust/contentrust.go 80.00% <50.00%> (-1.14%) ⬇️

... and 9 files with indirect coverage changes

@wy65701436 wy65701436 added release-note/ignore-for-release Do not include PR or Issue for release notes target/2.9.0 labels Jul 25, 2023
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 force-pushed the add-signer-name branch 3 times, most recently from 0e9b81c to 4582df5 Compare July 25, 2023 09:05
Append the signer name to the error message which will be returned by the client

Signed-off-by: wang yan <wangyan@vmware.com>
@YangJiao0817 YangJiao0817 merged commit db82d6e into goharbor:main Jul 25, 2023
lengrongfu pushed a commit to lengrongfu/harbor that referenced this pull request Aug 1, 2023
Append the signer name to the error message which will be returned by the client

Signed-off-by: wang yan <wangyan@vmware.com>
Signed-off-by: lengrongfu <1275177125@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants