Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build harbor-db-base error #19003

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 25, 2023

Fix #19002

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Fix goharbor#19002

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #19003 (6b42b97) into main (d92aca9) will decrease coverage by 22.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19003       +/-   ##
===========================================
- Coverage   67.43%   44.92%   -22.52%     
===========================================
  Files         992      244      -748     
  Lines      108725    13386    -95339     
  Branches     2747     2747               
===========================================
- Hits        73319     6013    -67306     
+ Misses      31474     7068    -24406     
+ Partials     3932      305     -3627     
Flag Coverage Δ
unittests 44.92% <ø> (-22.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 752 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 70554fe into goharbor:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build release-note/infra Infra related changes e.g. release, test, ship etc... target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build harbor-db-base error
6 participants