Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation hint #19024

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented Jul 26, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19016

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang added the release-note/update Update or Fix label Jul 26, 2023
@MinerYang MinerYang requested a review from a team as a code owner July 26, 2023 09:22
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #19024 (6c5c991) into main (db82d6e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19024   +/-   ##
=======================================
  Coverage   67.43%   67.43%           
=======================================
  Files         992      992           
  Lines      108727   108727           
  Branches     2747     2747           
=======================================
+ Hits        73316    73321    +5     
+ Misses      31479    31476    -3     
+ Partials     3932     3930    -2     
Flag Coverage Δ
unittests 67.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit 3af605e into goharbor:main Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should provide valid error message when using --with-notary parameter
6 participants