Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]fix accessory import issue #19056

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 31, 2023

fixes #19041

The issuse was introduced by #17087. To move the import to main since the anonymous imports only allowed at main in go-cilint.

Fixes it:
To add the anonymous imports at the jobservice main since the gc job needs to remove accessory when to delete an artifact

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner July 31, 2023 03:41
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #19056 (ec42edb) into release-2.7.0 (9151435) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #19056      +/-   ##
=================================================
- Coverage          66.40%   66.38%   -0.02%     
=================================================
  Files               1012     1012              
  Lines             108652   108652              
  Branches            2677     2677              
=================================================
- Hits               72152    72132      -20     
- Misses             32534    32555      +21     
+ Partials            3966     3965       -1     
Flag Coverage Δ
unittests 66.38% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@wy65701436 wy65701436 assigned zyyw and chlins and unassigned OrlinVasilev Jul 31, 2023
@wy65701436 wy65701436 changed the title fix accessory import issue [cherry-pick]fix accessory import issue Jul 31, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fixes goharbor#19041

The issuse was introduced by goharbor#17087.
To move the import to main since the anonymous imports only allowed at main in go-cilint.

Fixes it:
To add the anonymous imports at the jobservice main since the gc job needs to remove accessory when to delete an artifact

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 merged commit e767fe2 into goharbor:release-2.7.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants