Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dry run creation time #19060

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix dry run creation time #19060

merged 2 commits into from
Jul 31, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jul 31, 2023

Give the mock time for dry run, otherwise, it will be zero.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner July 31, 2023 06:58
fixes goharbor#19059
Give the mock time for dry run, otherwise, it will be zero.

Signed-off-by: wang yan <wangyan@vmware.com>
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #19060 (d577b2c) into main (bef4ccc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19060      +/-   ##
==========================================
- Coverage   67.42%   67.41%   -0.01%     
==========================================
  Files         992      992              
  Lines      108738   108739       +1     
  Branches     2748     2748              
==========================================
- Hits        73312    73303       -9     
- Misses      31494    31504      +10     
  Partials     3932     3932              
Flag Coverage Δ
unittests 67.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/jobservice/job/impl/gc/garbage_collection.go 45.95% <0.00%> (-0.10%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit d93f24a into goharbor:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants