Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update security hub ui #19062

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Update security hub ui #19062

merged 1 commit into from
Jul 31, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 31, 2023 •
edited
Loading

  1. Fixes UI issus of most danerous CVEs #19010
  2. Fixes Revise the words of the filter condition  #19011
  3. Fixes The redirection link of the N/A CVE is not correct #19012
  4. Fixes Duplicate CVE ID filter when jump from top CVEs #19015
  5. Fixes Duplicate project calls on the artifact redirection of secuity hub page #19025
  6. Fixes When the project name is a number, the security hub Filtering project not found. #19026
  7. Fixes The security hub filter does not remove spaces #19034
  8. Fixes Security hub searches for non-existent project issue #19037

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner July 31, 2023 09:40
@AllForNothing AllForNothing added the release-note/update Update or Fix label Jul 31, 2023
wy65701436
wy65701436 approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Update security hub ui
13fd6bd 
1. Fixes goharbor#19010
2. Fixes goharbor#19011
3. Fixes goharbor#19012
4. Fixes goharbor#19015
5. Fixes goharbor#19025
6. Fixes goharbor#19026
7. Fixes goharbor#19034
8. Fixes goharbor#19037

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #19062 (17c5e9a) into main (d93f24a) will increase coverage by 3.14%.
The diff coverage is n/a.

❗ Current head 17c5e9a differs from pull request most recent head 13fd6bd. Consider uploading reports for the commit 13fd6bd to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19062      +/-   ##
==========================================
+ Coverage   67.40%   70.55%   +3.14%     
==========================================
  Files         992      748     -244     
  Lines      108739    95349   -13390     
  Branches     2748        0    -2748     
==========================================
- Hits        73296    67271    -6025     
+ Misses      31513    24449    -7064     
+ Partials     3930     3629     -301
Flag Coverage Δ
unittests 70.55% <ø> (+3.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 251 files with indirect coverage changes

@AllForNothing AllForNothing merged commit 854e029 into goharbor:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangJiao0817 YangJiao0817 YangJiao0817 approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@AllForNothing AllForNothing

Labels
release-note/update Update or Fix
Projects
None yet
Milestone
No milestone
5 participants
@AllForNothing @wy65701436 @YangJiao0817 @stonezdj @chlins