Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump golang 1.20.6 on main #19066

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

MinerYang
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@MinerYang MinerYang requested a review from a team as a code owner August 1, 2023 03:55
@MinerYang MinerYang changed the title bump golang 1.20.6 bump golang 1.20.6 on main Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #19066 (b053d1e) into main (39ec1e4) will decrease coverage by 3.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19066      +/-   ##
==========================================
- Coverage   70.58%   67.38%   -3.21%     
==========================================
  Files         748      992     +244     
  Lines       95349   108753   +13404     
  Branches        0     2750    +2750     
==========================================
+ Hits        67305    73281    +5976     
- Misses      24416    31541    +7125     
- Partials     3628     3931     +303     
Flag Coverage Δ
unittests 67.38% <ø> (-3.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 252 files with indirect coverage changes

Signed-off-by: yminer <yminer@vmware.com>
@MinerYang MinerYang force-pushed the bump_golang1.20.6_main branch from 015fdd3 to b053d1e Compare August 2, 2023 01:40
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang MinerYang merged commit e1c1f56 into goharbor:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants