Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style for add-replication-rule page #19100

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 4, 2023

  1. Fixes Delete an accessory cannot trigger Event based replication #19098

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1. Fixes goharbor#19098

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing requested a review from a team as a code owner August 4, 2023 02:54
@AllForNothing AllForNothing self-assigned this Aug 4, 2023
@AllForNothing AllForNothing added the release-note/update Update or Fix label Aug 4, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #19100 (930d707) into main (8c23bcd) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19100      +/-   ##
==========================================
+ Coverage   67.38%   67.40%   +0.02%     
==========================================
  Files         992      992              
  Lines      108754   108754              
  Branches     2751     2751              
==========================================
+ Hits        73281    73306      +25     
+ Misses      31540    31520      -20     
+ Partials     3933     3928       -5     
Flag Coverage Δ
unittests 67.40% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@AllForNothing AllForNothing merged commit f8cf772 into goharbor:main Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete an accessory cannot trigger Event based replication
5 participants