Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui to fix some issues #19101

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 4, 2023

  1. Add digest filter for vulnerability search, for Add digest option in Security Hub Vulnerabilities filter #19023
  2. Fixes Banner Message clicked close and then jumped to artifact page and displayed again #19104

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #19101 (5a59c98) into main (a036e4a) will decrease coverage by 0.02%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19101      +/-   ##
==========================================
- Coverage   44.90%   44.88%   -0.02%     
==========================================
  Files         244      244              
  Lines       13405    13412       +7     
  Branches     2751     2751              
==========================================
+ Hits         6019     6020       +1     
- Misses       7081     7087       +6     
  Partials      305      305              
Flag Coverage Δ
unittests 44.88% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/vulnerability-database/security-hub.component.ts 47.14% <0.00%> (-0.69%) ⬇️
...erability-filter/vulnerability-filter.component.ts 25.00% <ø> (ø)
...nts/app-level-alerts/app-level-alerts.component.ts 40.65% <0.00%> (-0.92%) ⬇️
src/portal/src/app/services/app-config.service.ts 57.14% <33.33%> (-2.86%) ⬇️
...ability-summary/vulnerability-summary.component.ts 68.57% <50.00%> (ø)
...s/vulnerability-database/security-hub.interface.ts 77.77% <100.00%> (+0.85%) ⬆️

... and 2 files with indirect coverage changes

@AllForNothing AllForNothing force-pushed the digest branch 2 times, most recently from ad6fef3 to eacb442 Compare August 7, 2023 03:11
@AllForNothing AllForNothing changed the title Add digest filter for vulnerability search Update ui to fix some issues Aug 7, 2023
1. Add digest filter for vulnerability search, for goharbor#19023
2. Fixes goharbor#19104

Signed-off-by: AllForNothing <sshijun@vmware.com>
@YangJiao0817 YangJiao0817 merged commit 958bed2 into goharbor:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner Message clicked close and then jumped to artifact page and displayed again
5 participants