Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add artifact digest to query condition #19102

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Aug 4, 2023

Fixes #19023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner August 4, 2023 07:53
@stonezdj stonezdj assigned wy65701436 and unassigned zyyw and OrlinVasilev Aug 4, 2023
@stonezdj stonezdj force-pushed the 23aug04_add_digest_filter branch from 3598cbd to 1bf4642 Compare August 4, 2023 07:55
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #19102 (e3d356f) into main (3de778e) will increase coverage by 22.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19102       +/-   ##
===========================================
+ Coverage   44.90%   67.39%   +22.49%     
===========================================
  Files         244      992      +748     
  Lines       13405   108768    +95363     
  Branches     2751     2751               
===========================================
+ Hits         6019    73303    +67284     
- Misses       7080    31526    +24446     
- Partials      306     3939     +3633     
Flag Coverage Δ
unittests 67.39% <100.00%> (+22.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/securityhub/dao/security.go 59.60% <100.00%> (ø)

... and 750 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  Fixes goharbor#19023

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 23aug04_add_digest_filter branch from 1bf4642 to e3d356f Compare August 7, 2023 00:41
@stonezdj stonezdj merged commit c62ec7d into goharbor:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add digest option in Security Hub Vulnerabilities filter
5 participants