Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort most dangerous vulnerabilities by score and severity level #19103

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Aug 4, 2023

Check it is referred by a scan_report
Add index to report_vulnerability_record to improve performance
Fixes #19014 #19028

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner August 4, 2023 08:50
@stonezdj stonezdj added the release-note/update Update or Fix label Aug 4, 2023
@stonezdj stonezdj assigned chlins and unassigned AllForNothing Aug 4, 2023
@stonezdj stonezdj force-pushed the 23aug04_sort_top_cve branch from b45b7d1 to 6d90e3d Compare August 4, 2023 08:54
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #19103 (dede4ba) into main (c62ec7d) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19103      +/-   ##
==========================================
+ Coverage   67.39%   67.42%   +0.02%     
==========================================
  Files         992      992              
  Lines      108768   108768              
  Branches     2751     2751              
==========================================
+ Hits        73308    73334      +26     
+ Misses      31525    31496      -29     
- Partials     3935     3938       +3     
Flag Coverage Δ
unittests 67.42% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/securityhub/dao/security.go 59.60% <ø> (ø)

... and 7 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23aug04_sort_top_cve branch from 6d90e3d to a033bf4 Compare August 6, 2023 02:46
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23aug04_sort_top_cve branch from a033bf4 to b435b4b Compare August 7, 2023 00:41
  Check it is referred by a scan_report
  Add index to report_vulnerability_record to improve performance
  Fixes goharbor#19014 goharbor#19028

Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 23aug04_sort_top_cve branch from b435b4b to dede4ba Compare August 7, 2023 01:25
@stonezdj stonezdj merged commit 0e92eae into goharbor:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The sort of top 5 dangerous CVEs
5 participants