Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect artifact and scanned artifact count issue #19106

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Aug 4, 2023

Update sql to count artifact and scanned artifact

fixes #19009 #19020 #19013

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner August 4, 2023 11:44
@stonezdj stonezdj assigned chlins and unassigned Vad1mo and MinerYang Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #19106 (10b35a6) into main (f8cf772) will increase coverage by 0.04%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19106      +/-   ##
==========================================
+ Coverage   67.36%   67.41%   +0.04%     
==========================================
  Files         992      992              
  Lines      108754   108763       +9     
  Branches     2751     2751              
==========================================
+ Hits        73264    73319      +55     
+ Misses      31555    31508      -47     
- Partials     3935     3936       +1     
Flag Coverage Δ
unittests 67.41% <55.55%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/securityhub/manager.go 22.22% <0.00%> (-2.78%) ⬇️
src/pkg/securityhub/dao/security.go 50.50% <50.00%> (-0.30%) ⬇️
src/controller/securityhub/controller.go 76.08% <100.00%> (+0.04%) ⬆️

... and 11 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23aug03_fix_incorrect_count branch 2 times, most recently from 4ddc54c to 5e90705 Compare August 6, 2023 02:52
@stonezdj stonezdj force-pushed the 23aug03_fix_incorrect_count branch from 5e90705 to 9bfbe45 Compare August 6, 2023 03:35
Signed-off-by: stonezdj <daojunz@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 3de778e into goharbor:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The scanner count doesn't correct in the security hub page
5 participants