Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] chore: fix incorrect otel timeout in harbor yaml template #19122

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 8, 2023

Update the incorrect otel timeout sample value in the harbor YAML configuration template.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19084

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Update the incorrect otel timeout sample value in the harbor YAML
configuration template.

Signed-off-by: chlins <chenyuzh@vmware.com>
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #19122 (37382e0) into release-2.8.0 (cd31bcb) will decrease coverage by 0.02%.
Report is 1 commits behind head on release-2.8.0.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19122      +/-   ##
=================================================
- Coverage          67.38%   67.36%   -0.02%     
=================================================
  Files                984      984              
  Lines             107027   107027              
  Branches            2671     2671              
=================================================
- Hits               72118    72102      -16     
- Misses             31027    31046      +19     
+ Partials            3882     3879       -3     
Flag Coverage Δ
unittests 67.36% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 0de5006 into goharbor:release-2.8.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants