Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] fix: add storage_limit check (add ValidateQuotaLimit as a general met… #19144

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Aug 10, 2023

…hod to validate quota limit value)

cherry pick of this PR:

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…hod to validate quota limit value)

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #19144 (af540d0) into release-2.9.0 (92e468c) will increase coverage by 0.00%.
The diff coverage is 56.52%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-2.9.0   #19144   +/-   ##
==============================================
  Coverage          67.43%   67.44%           
==============================================
  Files                992      993    +1     
  Lines             108791   108812   +21     
  Branches            2751     2751           
==============================================
+ Hits               73358    73383   +25     
+ Misses             31494    31490    -4     
  Partials            3939     3939           
Flag Coverage Δ
unittests 67.44% <56.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/config/manager.go 45.23% <0.00%> (-3.90%) ⬇️
src/pkg/quota/types/resources.go 83.56% <ø> (ø)
src/controller/quota/driver/project/project.go 39.13% <100.00%> (+15.94%) ⬆️
src/lib/quota_storage_limit.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 0a232ff into goharbor:release-2.9.0 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants