Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] refactor: migrate the redis command keys to scan #19148

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 10, 2023

Refine the cache interface, migrate the Keys to Scan, change the redis underlying keys command to scan.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #19148 (d3f625a) into release-2.7.0 (7c6e292) will increase coverage by 0.01%.
Report is 1 commits behind head on release-2.7.0.
The diff coverage is 75.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #19148      +/-   ##
=================================================
+ Coverage          66.39%   66.41%   +0.01%     
=================================================
  Files               1012     1012              
  Lines             108654   108674      +20     
  Branches            2678     2678              
=================================================
+ Hits               72145    72175      +30     
+ Misses             32546    32534      -12     
- Partials            3963     3965       +2     
Flag Coverage Δ
unittests 66.41% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/cache/cache.go 92.68% <ø> (-7.32%) ⬇️
src/pkg/cached/project_metadata/redis/manager.go 46.37% <0.00%> (ø)
src/pkg/cached/base_manager.go 40.00% <36.36%> (-2.86%) ⬇️
src/lib/cache/redis/redis.go 69.91% <77.77%> (+0.54%) ⬆️
src/lib/cache/memory/memory.go 89.65% <100.00%> (+6.09%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the release-2.7/refactor/redis-scan branch from 11bd7b8 to f3ce30d Compare August 16, 2023 01:12
Refine the cache interface, migrate the Keys to Scan, change the redis
underlying keys command to scan.

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins force-pushed the release-2.7/refactor/redis-scan branch from f3ce30d to d3f625a Compare August 16, 2023 02:23
@chlins chlins merged commit 3db3d60 into goharbor:release-2.7.0 Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants