Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: change log level to reduce the noise logs #19165

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 14, 2023

  1. Change some logs level to reduce the noise.
  2. Wrap the go-redis.Nil error as ErrNotFound to avoid confusing

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1. Change some logs level to reduce the noise.
2. Wrap the go-redis.Nil error as ErrNotFound to avoid confusing

Signed-off-by: chlins <chenyuzh@vmware.com>
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #19165 (7c0013f) into release-2.9.0 (fbdc03b) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19165      +/-   ##
=================================================
- Coverage          67.42%   67.39%   -0.03%     
=================================================
  Files                993      993              
  Lines             108864   108866       +2     
  Branches            2751     2751              
=================================================
- Hits               73397    73372      -25     
- Misses             31518    31547      +29     
+ Partials            3949     3947       -2     
Flag Coverage Δ
unittests 67.39% <57.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/session/session.go 34.82% <0.00%> (ø)
src/server/registry/manifest.go 66.90% <0.00%> (ø)
src/lib/cache/redis/redis.go 71.30% <100.00%> (-0.38%) ⬇️
src/pkg/notifier/notifier.go 82.35% <100.00%> (ø)

... and 9 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo Vad1mo self-requested a review August 14, 2023 06:21
@Vad1mo Vad1mo merged commit 8ad19e7 into goharbor:release-2.9.0 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants