Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore spaces for vulnerability filters #19180

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 15, 2023

1.Fixes #19168

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1.Fixes goharbor#19168

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #19180 (674ef71) into main (661c762) will decrease coverage by 3.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19180      +/-   ##
==========================================
- Coverage   70.59%   67.42%   -3.17%     
==========================================
  Files         749      993     +244     
  Lines       95452   108864   +13412     
  Branches        0     2751    +2751     
==========================================
+ Hits        67384    73404    +6020     
- Misses      24425    31514    +7089     
- Partials     3643     3946     +303     
Flag Coverage Δ
unittests 67.42% <0.00%> (-3.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...erability-filter/vulnerability-filter.component.ts 25.00% <0.00%> (ø)

... and 247 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 296e905 into goharbor:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Hub search input box enter space to search for error
6 participants