Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: support customize cache db for business #19190

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 16, 2023

Support to configure the customized redis db for cache layer and other misc business for core, by default the behavior is same with previous(stored in db 0).

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19169

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Support to configure the customized redis db for cache layer and other
misc business for core, by default the behavior is same with
previous(stored in db 0).

Signed-off-by: chlins <chenyuzh@vmware.com>
@chlins chlins requested a review from a team as a code owner August 16, 2023 05:07
@chlins chlins added the release-note/update Update or Fix label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #19190 (6f7405e) into release-2.9.0 (05cb1d7) will decrease coverage by 22.62%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #19190       +/-   ##
==================================================
- Coverage          67.40%   44.79%   -22.62%     
==================================================
  Files                993      244      -749     
  Lines             108866    13412    -95454     
  Branches            2751     2751               
==================================================
- Hits               73386     6008    -67378     
+ Misses             31536     7099    -24437     
+ Partials            3944      305     -3639     
Flag Coverage Δ
unittests 44.79% <ø> (-22.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 755 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit e1f95ca into goharbor:release-2.9.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants