Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete tag retention rule and tag immutable rule when deleting project #19390

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Sep 22, 2023

fixes #18250

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner September 22, 2023 07:10
@stonezdj stonezdj changed the title Refactor notification of delete project Delete tag retention rule and tag immutable rule when deleting project Sep 22, 2023
@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch from c289be3 to 89ca5bf Compare September 22, 2023 07:11
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #19390 (fb5ea1d) into main (a1effcb) will decrease coverage by 22.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19390       +/-   ##
===========================================
- Coverage   67.48%   44.87%   -22.61%     
===========================================
  Files         988      244      -744     
  Lines      108771    13417    -95354     
  Branches     2752     2752               
===========================================
- Hits        73400     6021    -67379     
+ Misses      31416     7090    -24326     
+ Partials     3955      306     -3649     
Flag Coverage Δ
unittests 44.87% <ø> (-22.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 746 files with indirect coverage changes

@stonezdj stonezdj added the release-note/update Update or Fix label Sep 22, 2023
@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch 3 times, most recently from 470ad6e to 19a0ff8 Compare September 22, 2023 08:57
@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch from 19a0ff8 to feda341 Compare September 23, 2023 09:31
@chlins
Copy link
Member

chlins commented Oct 11, 2023

The src/controller/event/handler/internal/artifact.go is the internal event controller for the artifact, should only process the events related to artifact, so for project I think we should add a new file project.go to handle, and will be more extensible for other project events in the future.

@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch 2 times, most recently from 900c095 to c923a27 Compare October 19, 2023 02:57
@stonezdj stonezdj enabled auto-merge (squash) October 19, 2023 02:58
@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch from c923a27 to 2604b4b Compare October 19, 2023 05:57
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch from 2604b4b to a3baa73 Compare October 23, 2023 03:09
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23sep15_subscribe_event branch from a3baa73 to fb5ea1d Compare October 24, 2023 03:37
@stonezdj stonezdj merged commit 7b0beed into goharbor:main Oct 24, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tag retention and tag immutable policies are not deleted after deleting the project
5 participants