Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick]Hide version property if the value is undefined #19396

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Sep 26, 2023

1.Related issue #19391

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

1.Related issue goharbor#19391

Signed-off-by: AllForNothing <sshijun@vmware.com>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #19396 (d328c38) into release-2.9.0 (3c62b75) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.9.0   #19396      +/-   ##
=================================================
+ Coverage          67.39%   67.41%   +0.01%     
=================================================
  Files                993      993              
  Lines             108921   108921              
  Branches            2752     2752              
=================================================
+ Hits               73407    73427      +20     
+ Misses             31566    31548      -18     
+ Partials            3948     3946       -2     
Flag Coverage Δ
unittests 67.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 6f85d59 into goharbor:release-2.9.0 Sep 28, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants