Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 19392 #19437

Merged
merged 2 commits into from
Oct 12, 2023
Merged

fix issue 19392 #19437

merged 2 commits into from
Oct 12, 2023

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Oct 11, 2023

Needs to set the repo when to handle the accessory before subject manifest.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Needs to set the repo when to handle the accessory before subject manifest.

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner October 11, 2023 09:03
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #19437 (be29727) into main (663d0b8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19437      +/-   ##
==========================================
- Coverage   67.47%   67.46%   -0.02%     
==========================================
  Files         988      988              
  Lines      108732   108732              
  Branches     2752     2752              
==========================================
- Hits        73367    73351      -16     
- Misses      31417    31435      +18     
+ Partials     3948     3946       -2     
Flag Coverage Δ
unittests 67.46% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/server/middleware/subject/subject.go 48.48% <100.00%> (ø)

... and 4 files with indirect coverage changes

@wy65701436 wy65701436 added the release-note/update Update or Fix label Oct 12, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit f9ab185 into goharbor:main Oct 12, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants