-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Accessibility - change color for WCAG AA #19472
fix: Accessibility - change color for WCAG AA #19472
Conversation
Head branch was pushed to by a user without write access
Thanks @Vad1mo for the swift review and sorry about the auto-merge, I just pushed to fix the reason of UI_UT CI job's failure. |
Codecov Report
@@ Coverage Diff @@
## main #19472 +/- ##
==========================================
+ Coverage 67.43% 67.46% +0.03%
==========================================
Files 989 989
Lines 108836 108836
Branches 2752 2752
==========================================
+ Hits 73394 73428 +34
+ Misses 31480 31446 -34
Partials 3962 3962
Flags with carried forward coverage won't be shown. Click here to find out more. |
@SphinxKnight Can you update the background color according to this #19249? The new colors this suggested by our designer. |
Thanks for the pointer: just did in fdaab42 Edit: screenshot with the new values updated in the description. Also included here for simplicity: |
@SphinxKnight thank you for the PR :)) |
Signed-off-by: julieng <julien.gattelier@gmail.com>
Signed-off-by: julieng <julien.gattelier@gmail.com>
Signed-off-by: julieng <julien.gattelier@gmail.com>
fdaab42
to
3bf7872
Compare
@SphinxKnight congrats on merging your first PR here :) |
Thanks :) eager to learn a bit more SASS to factor those tokens when time allows :) |
Comprehensive Summary of your change
Changed the label token foreground and background to comply with WCAG AA (or AAA when possible).
Before:
After:
Using https://webaim.org/resources/contrastchecker/ as a testing tool, only
label-medium
was OK for WCAG AA for normal content.Issue being fixed
No existing issue (I preferred to file a PR first). This could relate to #12327
Notes
I don't have any Sass skill so far and tried to apply a homogeneous patch where such labels were duplicated. Please let me know if I missed something.
result-tip-histogram.component.scss
didn't have any issue, but I preferred to match the colors changed elsewhere.Please indicate you've done the following: