-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete project member when delete project #19523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #19523 +/- ##
==========================================
+ Coverage 67.50% 67.51% +0.01%
==========================================
Files 988 988
Lines 108780 108792 +12
Branches 2737 2737
==========================================
+ Hits 73431 73450 +19
+ Misses 31384 31374 -10
- Partials 3965 3968 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wy65701436
reviewed
Nov 2, 2023
wy65701436
reviewed
Nov 2, 2023
zyyw
reviewed
Nov 3, 2023
stonezdj
force-pushed
the
23oct31_remove_project_member
branch
from
November 4, 2023 02:25
8f1ff84
to
4749983
Compare
zyyw
approved these changes
Nov 6, 2023
stonezdj
force-pushed
the
23oct31_remove_project_member
branch
from
November 8, 2023 08:19
4749983
to
dd6bf2a
Compare
Signed-off-by: stonezdj <daojunz@vmware.com>
stonezdj
force-pushed
the
23oct31_remove_project_member
branch
from
November 8, 2023 08:41
dd6bf2a
to
6db2358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: