Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete project member when delete project #19523

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Nov 2, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner November 2, 2023 02:54
@stonezdj stonezdj added the release-note/update Update or Fix label Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #19523 (6db2358) into main (bfd44b9) will increase coverage by 0.01%.
The diff coverage is 35.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19523      +/-   ##
==========================================
+ Coverage   67.50%   67.51%   +0.01%     
==========================================
  Files         988      988              
  Lines      108780   108792      +12     
  Branches     2737     2737              
==========================================
+ Hits        73431    73450      +19     
+ Misses      31384    31374      -10     
- Partials     3965     3968       +3     
Flag Coverage Δ
unittests 67.51% <35.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/member/manager.go 23.52% <100.00%> (+17.27%) ⬆️
src/controller/event/handler/internal/project.go 13.04% <0.00%> (-13.05%) ⬇️
src/pkg/member/dao/dao.go 71.79% <40.00%> (-1.72%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23oct31_remove_project_member branch from 8f1ff84 to 4749983 Compare November 4, 2023 02:25
@stonezdj stonezdj force-pushed the 23oct31_remove_project_member branch from 4749983 to dd6bf2a Compare November 8, 2023 08:19
Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 23oct31_remove_project_member branch from dd6bf2a to 6db2358 Compare November 8, 2023 08:41
@stonezdj stonezdj merged commit da949bf into goharbor:main Nov 8, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants