Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct loop condition for replication tasks #19570

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Nov 13, 2023

1.Correct loop condition for replication tasks page

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #19570 (6caf5dc) into main (da9e263) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19570      +/-   ##
==========================================
- Coverage   45.35%   45.29%   -0.07%     
==========================================
  Files         244      244              
  Lines       13324    13323       -1     
  Branches     2720     2719       -1     
==========================================
- Hits         6043     6034       -9     
- Misses       6977     6987      +10     
+ Partials      304      302       -2     
Flag Coverage Δ
unittests 45.29% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/replication-tasks/replication-tasks.component.ts 49.51% <0.00%> (+0.47%) ⬆️

... and 5 files with indirect coverage changes

@AllForNothing AllForNothing enabled auto-merge (squash) November 14, 2023 08:43
@AllForNothing AllForNothing force-pushed the ui-issue branch 2 times, most recently from 55127d5 to b0e6399 Compare November 15, 2023 04:49
Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit 95b4032 into goharbor:main Nov 15, 2023
16 of 18 checks passed
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Altynbaev Dinislam <altynbayevdr@sberautotech.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants