Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade github.com/gorilla/mux/otelmux to v0.44.0 #19620

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Nov 27, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #19620 (d3d63ef) into release-2.7.0 (c07f5ce) will increase coverage by 22.35%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.7.0   #19620       +/-   ##
==================================================
+ Coverage          44.03%   66.39%   +22.35%     
==================================================
  Files                245     1012      +767     
  Lines              13398   108728    +95330     
  Branches            2678     2678               
==================================================
+ Hits                5900    72187    +66287     
- Misses              7212    32572    +25360     
- Partials             286     3969     +3683     
Flag Coverage Δ
unittests 66.39% <ø> (+22.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 770 files with indirect coverage changes

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the upgrade-otelmux-to-v0.44.0 branch from 5898e1b to d3d63ef Compare November 27, 2023 02:06
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 005e993 into goharbor:release-2.7.0 Nov 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants