Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh base images on release-2.7.0 #19644

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Nov 29, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Yang Jiao <jiaoya@vmware.com>
@YangJiao0817 YangJiao0817 added release-note/infra Infra related changes e.g. release, test, ship etc... target/2.7.4 labels Nov 29, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner November 29, 2023 02:21
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) November 29, 2023 02:24
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #19644 (ca64b3b) into release-2.7.0 (005e993) will decrease coverage by 22.36%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.7.0   #19644       +/-   ##
==================================================
- Coverage          66.38%   44.03%   -22.36%     
==================================================
  Files               1012      245      -767     
  Lines             108728    13398    -95330     
  Branches            2678     2678               
==================================================
- Hits               72183     5900    -66283     
+ Misses             32578     7212    -25366     
+ Partials            3967      286     -3681     
Flag Coverage Δ
unittests 44.03% <ø> (-22.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 769 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 8693b25 into goharbor:release-2.7.0 Nov 29, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/infra Infra related changes e.g. release, test, ship etc... target/2.7.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants