Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Alibaba ACR proxy cache type #19692

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

njucjc
Copy link
Contributor

@njucjc njucjc commented Dec 11, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19693

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

PR for docs #519

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.09%. Comparing base (c8c11b4) to head (95c47af).
Report is 292 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19692       +/-   ##
===========================================
+ Coverage   45.36%   66.09%   +20.72%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114634   +101301     
  Branches     2719     2856      +137     
===========================================
+ Hits         6049    75762    +69713     
- Misses       6983    34729    +27746     
- Partials      301     4143     +3842     
Flag Coverage Δ
unittests 66.09% <ø> (+20.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

@stonezdj
Copy link
Contributor

@njucjc could you please share us an account to verify the PR in the Slack

@njucjc
Copy link
Contributor Author

njucjc commented Dec 12, 2023

@njucjc could you please share us an account to verify the PR in the Slack

@stonezdj I haven't joined the Slack now, I just email you the account

the ACR EE acount is for this PR #19658

@stonezdj stonezdj added the release-note/update Update or Fix label Dec 12, 2023
@stonezdj stonezdj force-pushed the add_acr_as_proxy_cache branch from 37bf1b3 to 2851eff Compare December 12, 2023 08:52
@stonezdj stonezdj self-requested a review January 24, 2024 13:14
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@njucjc
Copy link
Contributor Author

njucjc commented May 10, 2024

ping @stonezdj @wy65701436 . Any suggestion for this PR?

Copy link

github-actions bot commented Jul 9, 2024

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 9, 2024
@njucjc njucjc force-pushed the add_acr_as_proxy_cache branch from 3808dc3 to aa9e691 Compare July 31, 2024 02:49
@github-actions github-actions bot removed the Stale label Jul 31, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins
Copy link
Member

chlins commented Aug 5, 2024

Wait for #19658.

@chlins chlins force-pushed the add_acr_as_proxy_cache branch from aa9e691 to e934130 Compare September 2, 2024 08:43
@chlins chlins force-pushed the add_acr_as_proxy_cache branch from e934130 to aee3182 Compare October 11, 2024 10:36
@chlins
Copy link
Member

chlins commented Oct 11, 2024

@njucjc Please fix the DCO in CI.

Signed-off-by: njucjc <njucjc@gmail.com>
Signed-off-by: njucjc <njucjc@gmail.com>
@njucjc njucjc force-pushed the add_acr_as_proxy_cache branch from 548d08a to 95c47af Compare October 11, 2024 12:57
@njucjc
Copy link
Contributor Author

njucjc commented Oct 11, 2024

@njucjc Please fix the DCO in CI.

done

@stonezdj stonezdj merged commit 67d0fec into goharbor:main Oct 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harbor don't supports proxy caching for the Alibaba ACR registry
8 participants