add ip_family config in harbor.yml #19934

MinerYang · 2024-02-01T10:04:51Z

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

#19932

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

codecov · 2024-02-01T10:08:10Z

Codecov Report

Attention: 707 lines in your changes are missing coverage. Please review.

Comparison is base (24bbad1) 67.43% compared to head (2cc299f) 67.43%.
Report is 182 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #19934    +/-   ##
========================================
  Coverage   67.43%   67.43%            
========================================
  Files         993      996     +3     
  Lines      108982   109773   +791     
  Branches     2752     2720    -32     
========================================
+ Hits        73487    74030   +543     
- Misses      31536    31762   +226     
- Partials     3959     3981    +22

Flag	Coverage Δ
unittests	`67.43% <49.31%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/common/models/base.go	`100.00% <ø> (ø)`
src/common/rbac/project/rbac_role.go	`70.00% <ø> (ø)`
src/common/security/robot/context.go	`93.05% <100.00%> (+22.63%)`	⬆️
src/common/security/secret/context.go	`93.75% <100.00%> (ø)`
src/common/utils/uaa/fake_client.go	`94.00% <100.00%> (ø)`
src/common/utils/utils.go	`81.64% <100.00%> (+3.70%)`	⬆️
src/controller/artifact/annotation/v1alpha1.go	`64.81% <100.00%> (ø)`
src/controller/artifact/controller.go	`63.87% <100.00%> (+2.09%)`	⬆️
src/controller/artifact/processor/chart/chart.go	`61.76% <100.00%> (ø)`
src/controller/artifact/processor/cnab/cnab.go	`58.06% <100.00%> (ø)`
... and 154 more

... and 33 files with indirect coverage changes

zyyw · 2024-02-02T05:54:45Z

@MinerYang this PR will be merged into main, and the next release against main will be 2.11.0.
Please remove the label of target/2.9.3 and add the label of target/2.11.0.
Thanks

Signed-off-by: yminer <yminer@vmware.com> update name update prepare and migration update comments Signed-off-by: yminer <yminer@vmware.com> remove print msg update migrate template update default value update migrating template

make/harbor.yml.tmpl

make/photon/prepare/migrations/version_2_10_0/harbor.yml.jinja

make/photon/prepare/migrations/version_2_9_0/harbor.yml.jinja

zyyw · 2024-02-02T06:36:39Z

@MinerYang there is no values.yaml (the title of this PR: add ip_family config in values.yaml) for harbor offline-installer. Maybe change values.yaml to harbor.yml

wy65701436

lgtm

MinerYang added the release-note/update Update or Fix label Feb 1, 2024

MinerYang requested a review from a team as a code owner February 1, 2024 10:04

github-actions bot assigned chlins, OrlinVasilev and wy65701436 Feb 1, 2024

MinerYang force-pushed the add_ipFamily_config branch from 349e659 to 644c4d1 Compare February 1, 2024 10:13

MinerYang changed the title ~~add ipFamily config in values.yaml~~ add ip_family config in values.yaml Feb 1, 2024

MinerYang changed the title ~~add ip_family config in values.yaml~~ [WIP]add ip_family config in values.yaml Feb 1, 2024

MinerYang force-pushed the add_ipFamily_config branch 2 times, most recently from 6e0feec to 9879d66 Compare February 1, 2024 10:51

MinerYang assigned stonezdj and unassigned OrlinVasilev and chlins Feb 1, 2024

MinerYang changed the title ~~[WIP]add ip_family config in values.yaml~~ add ip_family config in values.yaml Feb 1, 2024

yanji09 added the target/2.9.3 label Feb 2, 2024

MinerYang force-pushed the add_ipFamily_config branch from 9879d66 to 496db99 Compare February 2, 2024 02:15

stonezdj approved these changes Feb 2, 2024

View reviewed changes

MinerYang force-pushed the add_ipFamily_config branch 2 times, most recently from b835973 to 561839b Compare February 2, 2024 03:43

MinerYang removed the target/2.9.3 label Feb 2, 2024

add ipFamily config in values.yaml

c1d4f8b

Signed-off-by: yminer <yminer@vmware.com> update name update prepare and migration update comments Signed-off-by: yminer <yminer@vmware.com> remove print msg update migrate template update default value update migrating template

MinerYang force-pushed the add_ipFamily_config branch from 561839b to c1d4f8b Compare February 2, 2024 06:07