Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBOM UI feature implementation #19946

Merged
merged 3 commits into from
Apr 18, 2024
Merged

SBOM UI feature implementation #19946

merged 3 commits into from
Apr 18, 2024

Conversation

xuelichao
Copy link
Contributor

@xuelichao xuelichao commented Feb 4, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Support to generate and down SBOM from harbor UI.

Mockups review link: (Access permission needed)
https://miro.com/app/board/uXjVN1ev40Q=/

Issue being fixed

Fixes #19132

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@xuelichao xuelichao force-pushed the sbom-ui branch 2 times, most recently from 0fee244 to 616d24d Compare February 5, 2024 04:16
@Vad1mo
Copy link
Member

Vad1mo commented Feb 11, 2024

@xuelichao can you attach the screenshots to the PR, not everyone in the community has access to the miro board.

@xuelichao
Copy link
Contributor Author

Screenshot 2024-01-31 at 11 07 42 Screenshot 2024-01-26 at 12 06 16 Screenshot 2024-01-26 at 12 05 38

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.38%. Comparing base (b7b8847) to head (2b2f405).
Report is 144 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19946       +/-   ##
===========================================
- Coverage   67.56%   46.38%   -21.18%     
===========================================
  Files         991      247      -744     
  Lines      109181    13751    -95430     
  Branches     2719     2827      +108     
===========================================
- Hits        73768     6379    -67389     
+ Misses      31449     7045    -24404     
+ Partials     3964      327     -3637     
Flag Coverage Δ
unittests 46.38% <ø> (-21.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@xuelichao xuelichao force-pushed the sbom-ui branch 2 times, most recently from 642afc7 to 5f95f23 Compare April 10, 2024 02:53
@xuelichao xuelichao changed the title draft: SBOM UI feature implementation SBOM UI feature implementation Apr 10, 2024
@xuelichao xuelichao force-pushed the sbom-ui branch 4 times, most recently from c9a08ae to 678de99 Compare April 12, 2024 06:57
@xuelichao xuelichao force-pushed the sbom-ui branch 5 times, most recently from 9687363 to 8747542 Compare April 18, 2024 04:47
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: xuelichao <xuel@vmware.com>
Signed-off-by: xuelichao <xuel@vmware.com>
Signed-off-by: xuelichao <xuel@vmware.com>
@stonezdj stonezdj enabled auto-merge (squash) April 18, 2024 07:49
@stonezdj stonezdj merged commit e8907a4 into goharbor:main Apr 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SBOM] UI implementation
5 participants