Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration tools #20075

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Mar 1, 2024

The previous migration tool overwrites existing OCI artifacts with the same name and same tag

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner March 1, 2024 08:40
@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Mar 1, 2024
Signed-off-by: stonezdj <daojunz@vmware.com>
@stonezdj stonezdj force-pushed the 24feb29_migration_tools branch from 855d709 to 000c866 Compare March 1, 2024 08:42
@stonezdj stonezdj enabled auto-merge (squash) March 1, 2024 08:45
@zyyw
Copy link
Contributor

zyyw commented Mar 1, 2024

how about change line 28 with open("/chart_storage/migration_errors.txt", "a") as f: in file tools/migrate_chart/migrate_chart.py to NOT append, just write into a file?

Also how about write a timestamp at beginning or end of the output file?

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vad1mo
Copy link
Member

Vad1mo commented Mar 5, 2024

I wonder hat does this code has to offer vs. https://github.com/goharbor/chartmuseum-migration-tools and why it should be part of the core project.

@stonezdj stonezdj merged commit 950fc06 into goharbor:main Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants