-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sbom_report table to store sbom related information #20473
Conversation
bae9176
to
a74ff38
Compare
a74ff38
to
88b43e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20473 +/- ##
===========================================
- Coverage 67.56% 46.35% -21.22%
===========================================
Files 991 247 -744
Lines 109181 13770 -95411
Branches 2719 2842 +123
===========================================
- Hits 73768 6383 -67385
+ Misses 31449 7059 -24390
+ Partials 3964 328 -3636
Flags with carried forward coverage won't be shown. Click here to find out more. |
88b43e3
to
ecb80ef
Compare
59071dd
to
82aad6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20473 +/- ##
===========================================
- Coverage 67.56% 46.24% -21.32%
===========================================
Files 991 247 -744
Lines 109181 13770 -95411
Branches 2719 2842 +123
===========================================
- Hits 73768 6368 -67400
+ Misses 31449 7074 -24375
+ Partials 3964 328 -3636
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
b55ae66
to
6beda61
Compare
fixes goharbor#20445 Refactor scan/base_controller.go Move MakeReportPlaceholder, GetReportPlaceholder, GetSummary to vul and sbom scanHandler Signed-off-by: stonezdj <stone.zhang@broadcom.com>
6beda61
to
fccc50a
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #20445
Please indicate you've done the following: