Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple SBOM #20503

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix multiple SBOM #20503

merged 2 commits into from
May 29, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented May 28, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.99%. Comparing base (b7b8847) to head (b86416e).
Report is 201 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20503      +/-   ##
==========================================
+ Coverage   67.56%   68.99%   +1.42%     
==========================================
  Files         991      798     -193     
  Lines      109181    99703    -9478     
  Branches     2719        0    -2719     
==========================================
- Hits        73768    68789    -4979     
+ Misses      31449    27137    -4312     
+ Partials     3964     3777     -187     
Flag Coverage Δ
unittests 68.99% <63.63%> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 52.25% <63.63%> (ø)

... and 325 files with indirect coverage changes

@wy65701436 wy65701436 force-pushed the fix-multiple-sbom branch 2 times, most recently from 6d0380b to 9170f47 Compare May 29, 2024 05:38
Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wy65701436 wy65701436 force-pushed the fix-multiple-sbom branch from ae0e33d to 0da8c56 Compare May 29, 2024 06:44
fixes goharbor#20496

Harbor will reserve one SBOM accessory artifact for each subject artifact. Ensure all existing SBOMs are removed before generating the next set.

Signed-off-by: wang yan <wangyan@vmware.com>

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 force-pushed the fix-multiple-sbom branch from 0da8c56 to 724af23 Compare May 29, 2024 06:46
@wy65701436 wy65701436 merged commit 7339bfa into goharbor:main May 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants