Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the execution vendor type sbom from image_scan #20504

Merged
merged 1 commit into from
May 29, 2024

Conversation

stonezdj
Copy link
Contributor

Add vendor type SBOM for execution
fixes #20495

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 28, 2024 12:47
@stonezdj stonezdj added the release-note/update Update or Fix label May 28, 2024
@stonezdj stonezdj requested review from wy65701436 and zyyw May 28, 2024 12:47
@stonezdj stonezdj assigned wy65701436 and zyyw and unassigned zyyw, chlins and MinerYang May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 66.25%. Comparing base (b7b8847) to head (600110a).
Report is 200 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20504      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.32%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113486    +4305     
  Branches     2719     2842     +123     
==========================================
+ Hits        73768    75190    +1422     
- Misses      31449    34191    +2742     
- Partials     3964     4105     +141     
Flag Coverage Δ
unittests 66.25% <69.23%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/scan/base_controller.go 56.82% <100.00%> (-2.73%) ⬇️
src/jobservice/job/known_jobs.go 0.00% <ø> (ø)
src/pkg/scan/handler.go 100.00% <ø> (ø)
src/pkg/scan/sbom/sbom.go 48.51% <0.00%> (ø)
src/pkg/scan/vulnerability/vul.go 56.68% <0.00%> (ø)

... and 568 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 24may28_index_status branch 3 times, most recently from 58eca27 to 67b0793 Compare May 29, 2024 05:31
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24may28_index_status branch from 67b0793 to a950be6 Compare May 29, 2024 05:50
  Add vendor type SBOM for execution
  fixes goharbor#20495

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24may28_index_status branch from a950be6 to 600110a Compare May 29, 2024 06:22
@stonezdj stonezdj merged commit 6d782ae into goharbor:main May 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBOM status of index should be consistent
5 participants