Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response an error message when there is incomplete sbom generate job #20526

Merged
merged 2 commits into from
May 31, 2024

Conversation

stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner May 31, 2024 07:30
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 66.25%. Comparing base (b7b8847) to head (bc82fa3).
Report is 207 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20526      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.31%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113488    +4307     
  Branches     2719     2844     +125     
==========================================
+ Hits        73768    75192    +1424     
- Misses      31449    34188    +2739     
- Partials     3964     4108     +144     
Flag Coverage Δ
unittests 66.25% <18.18%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/scan/sbom/sbom.go 51.98% <40.00%> (ø)
src/pkg/task/task.go 58.69% <0.00%> (-3.73%) ⬇️

... and 572 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 24may31_sbom_scan_reentry branch from 8b85691 to 91adfed Compare May 31, 2024 07:42
Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj force-pushed the 24may31_sbom_scan_reentry branch from 91adfed to 328abc7 Compare May 31, 2024 07:51
@stonezdj stonezdj changed the title Response an error message when there is uncomplete sbom generate job Response an error message when there is incomplete sbom generate job May 31, 2024
@zyyw zyyw merged commit 30767f6 into goharbor:main May 31, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants