-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes-20537 SBOM tab should not exist when the artifact is helm package #20538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuelichao
added a commit
to xuelichao/harbor
that referenced
this pull request
Jun 3, 2024
goharbor#20538 Signed-off-by: xuelichao <xuel@vmware.com>
xuelichao
added
the
release-note/ignore-for-release
Do not include PR or Issue for release notes
label
Jun 3, 2024
xuelichao
added a commit
to xuelichao/harbor
that referenced
this pull request
Jun 3, 2024
goharbor#20538 Signed-off-by: xuelichao <xuel@vmware.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20538 +/- ##
===========================================
- Coverage 67.56% 46.21% -21.36%
===========================================
Files 991 247 -744
Lines 109181 13777 -95404
Branches 2719 2845 +126
===========================================
- Hits 73768 6367 -67401
+ Misses 31449 7080 -24369
+ Partials 3964 330 -3634
Flags with carried forward coverage won't be shown. Click here to find out more. |
xuelichao
added a commit
to xuelichao/harbor
that referenced
this pull request
Jun 3, 2024
goharbor#20538 Signed-off-by: xuelichao <xuel@vmware.com>
…ant helm-chart Signed-off-by: xuelichao <xuel@vmware.com>
ywk253100
approved these changes
Jun 3, 2024
zyyw
approved these changes
Jun 3, 2024
zyyw
added
area/ui
area/SBOM
release-note/update
Update or Fix
and removed
release-note/ignore-for-release
Do not include PR or Issue for release notes
labels
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide SBOM tab when the artifact is helm package
Fixes #20537
Please indicate you've done the following: