bump up beego to v2.2.1 #20555

MinerYang · 2024-06-05T08:37:35Z

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Upstream behavior change:

https://github.com/uzziahlin/beego/blob/b9b8b8d2a9ec9f1b6e1a76b53b053d9cb7187b91/client/orm/db.go#L1375

Please indicate you've done the following:

Well Written Title and Summary of the PR
Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
Accepted the DCO. Commits without the DCO will delay acceptance.
Made sure tests are passing and test coverage is added if needed.
Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

codecov · 2024-06-05T08:43:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (b7b8847) to head (ce9c200).
Report is 232 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #20555      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.31%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113489    +4308     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75192    +1424     
- Misses      31449    34188    +2739     
- Partials     3964     4109     +145

Flag	Coverage Δ
unittests	`66.25% <100.00%> (-1.31%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/lib/orm/query.go	`76.27% <100.00%> (+2.68%)`	⬆️
src/pkg/artifact/dao/dao.go	`57.34% <100.00%> (ø)`
src/pkg/task/dao/execution.go	`61.82% <100.00%> (+0.47%)`	⬆️
src/pkg/task/dao/task.go	`64.31% <100.00%> (+0.10%)`	⬆️

... and 570 files with indirect coverage changes

zyyw · 2024-06-07T06:50:34Z

@MinerYang please resolve the conflict.

src/lib/orm/query.go

wy65701436

lgtm

chlins

lgtm

Signed-off-by: yminer <yminer@vmware.com> update artifact dao count update task dao count update execution dao count refactor disableSort option using Option struct instead of const remove comments use option func simplify

Per yan's comment above, we will do the rector releated thing in an other PR

Vad1mo · 2024-08-15T13:46:44Z

Supposes to fix #19401 and fix #20547

bump up beego v2.2.1 Fix vulnerablities: GHSA-wr3p-r5fj-wf97 GHSA-r6qh-j42j-pw64 Signed-off-by: yminer <yminer@vmware.com> Co-authored-by: hajnalmt <hajnalmt@gmail.com>

bump up beego v2.2.1 Signed-off-by: yminer <yminer@vmware.com> Co-authored-by: hajnalmt <hajnalmt@gmail.com>

bump up beego v2.2.1 Signed-off-by: hajnalmt <hajnalmt@gmail.com> Co-authored-by: yminer <yminer@vmware.com>

bump up beego v2.2.1 Co-authored-by: yminer <yminer@vmware.com> Signed-off-by: Mate Hajnal <hajnalmt@gmail.com>

bump up beego v2.2.1 Signed-off-by: Mate Hajnal <hajnalmt@gmail.com> Co-authored-by: MinerYang <yminer@vmware.com>

MinerYang added the release-note/ignore-for-release Do not include PR or Issue for release notes label Jun 5, 2024

MinerYang requested a review from a team as a code owner June 5, 2024 08:37

MinerYang force-pushed the test_beego_v2.2.1 branch from cf2007b to 5871ac1 Compare June 5, 2024 08:38

github-actions bot assigned chlins, OrlinVasilev and zyyw Jun 5, 2024

MinerYang changed the title ~~[DO NOT MERGE]test beego v2.2.1~~ test beego v2.2.1 Jun 5, 2024

MinerYang unassigned zyyw and OrlinVasilev Jun 5, 2024

wy65701436 mentioned this pull request Jun 5, 2024

GC Can delete that are not supposed to be deleted. #20547

Closed

MinerYang unassigned chlins Jun 5, 2024

MinerYang force-pushed the test_beego_v2.2.1 branch from 6f85beb to d18eaf1 Compare June 6, 2024 02:27

wy65701436 added the target/2.12.0 label Jun 6, 2024

MinerYang force-pushed the test_beego_v2.2.1 branch from d18eaf1 to b0f393a Compare June 6, 2024 13:26

MinerYang changed the title ~~test beego v2.2.1~~ [Do not merge]test beego v2.2.1 Jun 11, 2024

MinerYang force-pushed the test_beego_v2.2.1 branch from b0f393a to cba7370 Compare June 11, 2024 03:15

wy65701436 added the DONT MERGE label Jun 11, 2024

Vad1mo previously requested changes Jun 11, 2024

View reviewed changes

src/lib/orm/query.go Outdated Show resolved Hide resolved

MinerYang force-pushed the test_beego_v2.2.1 branch 2 times, most recently from da7b167 to 06ae5f4 Compare June 12, 2024 09:24

MinerYang force-pushed the test_beego_v2.2.1 branch 3 times, most recently from 0434a43 to 530bc33 Compare June 26, 2024 03:44

wy65701436 removed the DONT MERGE label Jun 26, 2024

wy65701436 assigned wy65701436 and chlins Jun 26, 2024

MinerYang changed the title ~~[Do not merge]test beego v2.2.1~~ bump up beego to v2.2.1 Jun 26, 2024

wy65701436 reviewed Jun 26, 2024

View reviewed changes

src/lib/orm/query.go Outdated Show resolved Hide resolved

MinerYang force-pushed the test_beego_v2.2.1 branch from 530bc33 to 3daaaae Compare June 26, 2024 07:24

wy65701436 approved these changes Jun 26, 2024

View reviewed changes

MinerYang force-pushed the test_beego_v2.2.1 branch 3 times, most recently from b812e66 to 8c1daf8 Compare June 26, 2024 11:33

chlins approved these changes Jun 26, 2024

View reviewed changes

MinerYang added release-note/update Update or Fix and removed release-note/ignore-for-release Do not include PR or Issue for release notes labels Jun 27, 2024

test beego v2.2.1

ce9c200

Signed-off-by: yminer <yminer@vmware.com> update artifact dao count update task dao count update execution dao count refactor disableSort option using Option struct instead of const remove comments use option func simplify

MinerYang force-pushed the test_beego_v2.2.1 branch from 8c1daf8 to ce9c200 Compare June 27, 2024 02:59

MinerYang enabled auto-merge (squash) June 27, 2024 06:37

MinerYang merged commit 562c01e into goharbor:main Jun 27, 2024
11 of 12 checks passed

This was referenced Jul 17, 2024

chore(deps): bump github.com/beego/beego/v2 from 2.0.6 to 2.2.1 in /src #20452

Closed

Bump up beego #20462

Closed

hajnalmt added a commit to hajnalmt/harbor that referenced this pull request Oct 4, 2024

[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)

12ac369

bump up beego v2.2.1 Signed-off-by: yminer <yminer@vmware.com> Co-authored-by: hajnalmt <hajnalmt@gmail.com>

hajnalmt pushed a commit to hajnalmt/harbor that referenced this pull request Oct 4, 2024

[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)

5eb52cf

bump up beego v2.2.1 Signed-off-by: hajnalmt <hajnalmt@gmail.com> Co-authored-by: yminer <yminer@vmware.com>

hajnalmt pushed a commit to hajnalmt/harbor that referenced this pull request Oct 4, 2024

[Cherrypick to v2.11] bump up beego to v2.2.1 (goharbor#20555)

6bbd3fe

bump up beego v2.2.1 Co-authored-by: yminer <yminer@vmware.com> Signed-off-by: Mate Hajnal <hajnalmt@gmail.com>

reasonerjt pushed a commit that referenced this pull request Nov 13, 2024

[Cherrypick to v2.11] bump up beego to v2.2.1 (#20555) (#21000)

5d2b1ec

bump up beego v2.2.1 Signed-off-by: Mate Hajnal <hajnalmt@gmail.com> Co-authored-by: MinerYang <yminer@vmware.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bump up beego to v2.2.1 #20555

bump up beego to v2.2.1 #20555

MinerYang commented Jun 5, 2024 •

edited

Loading

codecov bot commented Jun 5, 2024 •

edited

Loading

zyyw commented Jun 7, 2024

wy65701436 left a comment

chlins left a comment

Vad1mo commented Aug 15, 2024 •

edited

Loading

bump up beego to v2.2.1 #20555

bump up beego to v2.2.1 #20555

Conversation

MinerYang commented Jun 5, 2024 • edited Loading

Comprehensive Summary of your change

codecov bot commented Jun 5, 2024 • edited Loading

Codecov Report

zyyw commented Jun 7, 2024

wy65701436 left a comment

Choose a reason for hiding this comment

chlins left a comment

Choose a reason for hiding this comment

Vad1mo commented Aug 15, 2024 • edited Loading

MinerYang commented Jun 5, 2024 •

edited

Loading

codecov bot commented Jun 5, 2024 •

edited

Loading

Vad1mo commented Aug 15, 2024 •

edited

Loading