Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce the execution sweep job frequency from hourly to daily #20601

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 17, 2024

Reduce the execution sweep job frequency from hourly to daily.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20255

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner June 17, 2024 03:38
@chlins chlins assigned stonezdj and unassigned zyyw and AllForNothing Jun 17, 2024
@chlins chlins added the release-note/update Update or Fix label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.32%. Comparing base (b7b8847) to head (cfcce61).
Report is 222 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20601       +/-   ##
===========================================
- Coverage   67.56%   46.32%   -21.25%     
===========================================
  Files         991      247      -744     
  Lines      109181    13777    -95404     
  Branches     2719     2845      +126     
===========================================
- Hits        73768     6382    -67386     
+ Misses      31449     7065    -24384     
+ Partials     3964      330     -3634     
Flag Coverage Δ
unittests 46.32% <ø> (-21.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) June 17, 2024 10:30
Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the fix/reduce-execution-sweep-frequency branch from 3a56add to cfcce61 Compare June 17, 2024 10:30
@chlins chlins merged commit ac67161 into goharbor:main Jun 17, 2024
11 of 12 checks passed
zyyw pushed a commit to zyyw/harbor that referenced this pull request Jun 20, 2024
PR: goharbor#20601

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
wy65701436 pushed a commit that referenced this pull request Jun 20, 2024
fix: update the cron of execution sweep in test per the change of this
PR: #20601

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@another-novelty
Copy link

When is this fix going to be in a release? Or did I miss it in the release notes?

@chlins
Copy link
Member Author

chlins commented Oct 16, 2024

When is this fix going to be in a release? Or did I miss it in the release notes?

This issue was fixed in the version 2.11.

@another-novelty
Copy link

image
We currently have 2.11.1 installed, but the cron setting does not seem to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EXECUTION_SWEEP job queue is growing
6 participants